[COMPLETED] Contributor Invite: Don't run diagnostics on disabled modules

About this Contributor Invite:

  • Task Area: Coding
  • Effort rating: 1/5
  • Skills required: Python

Description of the Problem:

Currently, in FreedomBox, when we go to System -> Diagnostics and run diagnostics, it runs diagnostics on all installed apps. This includes apps that are disabled. Disabled apps obviously fail the tests and show up as failed. This is a problem.

What we ask of you:

We want to avoid running diagnostics on disabled modules. Just one task:

  • Ensure that diagnostics tests are not run on disabled modules. There are enumeration of modules when running diagnostics on all modules. During this enumeration, we already have a condition to skip modules that are not installed. Add another condition to skip apps that are disabled. For this access the app object for the modules with module.app and check with is_enabled() .

Link to the issue in GitLab: https://salsa.debian.org/freedombox-team/plinth/issues/1686

How to claim this Contributor Invite :

Do you want to accept this invitation to contribute? If so, follow these steps:

  1. Comment on this forum post indicating that you would like to claim the invite. This will prevent multiple people from working on the same issue at the same time.
  2. Register an account with our GitLab instance and begin making your contributions on the GitLab issue page for this task. You can use the comment section of this forum post to ask questions, but the bulk of the development discussion should happen on GitLab.


If you need help with this issue, please feel free to ask for it from members of our core team:

  • Sunil Mohan Adapa (@sunil): Lead Developer & Code Reviewer
  • Joseph Nuthalapati (@njoseph): DevOps Engineer, Developer, & Code Reviewer
  • James Valleroy (@jvalleroy) : Release Manager, Developer, & Code Reviewer

This invite has been completed see the issue report for details.