[CLAIMED] Contributor Invite: Get rid of tabs in the PageKite configuration page

About this Contributor Invite:

  • Task Area: Coding
  • Effort rating: 4/5
  • Skills required: Python, Django views/forms/templates/urls

Description of the Problem:

All most all apps in FreedomBox now follow a flat page structure instead of tabs (with exceptions). Pagekite still uses tabs and is not consistent with the new style of the FreedomBox UI. To make PageKite’s menu more consistent with the rest of the UI, we want to remove the tabs in the configuration page for PageKite.

What we ask of you:

Remove tabs in the configuration page (visit /plinth/apps/pagekite after installation) and show all the configuration options in a single view with multiple sections. See GitWeb configuration page for inspiration on how a single page configuration view looks like. Please follow these instructions:

  • Remove the tabs by removing subsubmenu in views.py. This will show only the configuration form.
  • Drop the Javascript code that expands and collapses the configuration when enable/disable checkbox is clicked. This inconsistent with other configuration pages we have.
  • Drop the standards service configuration form. Remove any code that is related to configuring standard services. Ensure that all the standard services are always enabled. After pagekite is installed, after it is enabled/disabled, etc.
  • Place the configuration form under the section title ‘Configuration’. See Gitweb app for how to style this.
  • Add a section with title ‘Custom Services’ in the main page. This should be below the ‘Configuration’ section. Show the list of custom services below it. This is essentially moving the listing part from older ‘Custom Services’ tab to the front page.
  • Move the add custom services form to a separate view. This view should look very simple and not have app description or tabs. See Gitweb’s add repository form view as an example.
  • Add a button ‘Add Custom Service’ under that ‘Custom Services’ section immediately after the title. This should redirect to the add custom services form view.
  • Cleanup any code that is unused after the changes.

Link to the issue in GitLab: https://salsa.debian.org/freedombox-team/plinth/issues/1693

How to claim this Contributor Invite :

Do you want to accept this invitation to contribute? If so, follow these steps:

  1. Comment on this forum post indicating that you would like to claim the invite. This will prevent multiple people from working on the same issue at the same time.
  2. Register an account with our GitLab instance and begin making your contributions on the GitLab issue page for this task. You can use the comment section of this forum post to ask questions, but the bulk of the development discussion should happen on GitLab.

Resources:

If you need help with this issue, please feel free to ask for it from members of our core team:

  • Sunil Mohan Adapa (@sunil): Lead Developer & Code Reviewer
  • Joseph Nuthalapati (@njoseph): DevOps Engineer, Developer, & Code Reviewer
  • James Valleroy (@jvalleroy) : Release Manager, Developer, & Code Reviewer

Following up on my conversation with Sunil at the hackathon yesterday, I would like to claim this invite!

2 Likes